fix(phpstan): restructure schedule-description branching for PHPStan 2.2#7
Merged
Merged
Conversation
PHPStan 2.2 (pulled fresh by CI, no lock tracked) flags the previous mutually exclusive if-chain as always-false/always-true via PHPDoc-certainty narrowing. Replaced with a nested decision tree that tests each cron field once per path - behavior unchanged, covered by existing Daily/Weekly/Monthly tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI pulls latest PHPStan (no composer.lock tracked); PHPStan 2.2 flags the mutually exclusive describe-if-chain as always-false/always-true via PHPDoc-certainty narrowing. Restructured into a nested decision tree (each cron field tested once per path). Behavior unchanged — existing Daily/Weekly/Monthly tests cover all branches. Local QA green with PHPStan 2.2.2.