refactor: correctly specify static lifetime for returned error#49
Open
Enduriel wants to merge 1 commit intojaredforth:mainfrom
Open
refactor: correctly specify static lifetime for returned error#49Enduriel wants to merge 1 commit intojaredforth:mainfrom
Enduriel wants to merge 1 commit intojaredforth:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Refactors error return types to use static lifetime instead of borrowing from input parameters, making error propagation easier by removing lifetime dependencies.
- Changes error return type from
&'a strto&'static strin twofrom_imagemethods - Eliminates the need for error values to be tied to the input parameter's lifetime
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/encoder.rs | Updates Encoder::from_image error return type to use static lifetime |
| src/animation_encoder.rs | Updates AnimFrame::from_image error return type to use static lifetime |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This previously made it very difficult to bubble up returned errors