Merged
Conversation
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on 98f387c..1906612
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• native/build-config.sh
2 tasks
jas88
added a commit
that referenced
this pull request
Mar 9, 2026
…#208) - Fixes CI failure on PR #207 where `--proto =https` blocked HTTP mirror redirects from ftpmirror.gnu.org, causing `xz: File format not recognized` - Adds SHA256 checksum verification for autoconf/automake downloads in CI workflow - Adds SHA256 checksums for all 8 native library downloads in `build-config.sh` - Updates `check-native-updates.sh` to auto-compute and update checksums when bumping versions
- Bump libxml2 from 2.15.1 to 2.15.2
1906612 to
af7099e
Compare
Removed trailing period from LIBXML2_SHA256 value.
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="native/build-config.sh">
<violation number="1" location="native/build-config.sh:20">
P0: SHA256 hash has a trailing period which will cause checksum verification to fail</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Dependency Updates
Changes
2.15.1→2.15.2Build Configuration Updated
native/build-config.sh- Updated version variablesTesting
CI will rebuild native libraries with updated versions and run tests on all platforms.
Notes
High-level PR Summary
This PR bumps the native libxml2 dependency from version 2.15.1 to 2.15.2 by updating the version variable in the build configuration script. The change is minimal and straightforward, involving only a single version number update. CI will rebuild the native libraries with the updated version and run tests across all platforms to ensure compatibility.
⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
native/build-config.shSummary by cubic
Update native
libxml2from 2.15.1 to 2.15.2 and fixLIBXML2_SHA256to match the 2.15.2 tarball (removed trailing period). UpdatedLIBXML2_VERSIONandLIBXML2_SHA256innative/build-config.sh; CI will rebuild and run tests across platforms.Written for commit 825b398. Summary will update on new commits.