Skip to content

Fix type size mismatches for MinGW builds#57

Merged
jasmcaus merged 1 commit intojasmcaus:devfrom
stefano-p:fix/static-assertion-failures
Aug 18, 2025
Merged

Fix type size mismatches for MinGW builds#57
jasmcaus merged 1 commit intojasmcaus:devfrom
stefano-p:fix/static-assertion-failures

Conversation

@stefano-p
Copy link
Contributor

Fix pointer type definitions for MinGW 64-bit compatibility

Addresses compilation failures on MinGW x86 and MSVC2019 builds.

- Fix pointer type definitions for MinGW 64-bit compatibility
- Add proper printf format specifiers using TAU_PRIu64

Addresses compilation failures on MinGW x86 and MSVC2019 builds.
@stefano-p stefano-p requested a review from jasmcaus as a code owner August 16, 2025 11:01
@stefano-p
Copy link
Contributor Author

At least Windows/mingw x86 checks are now all successful.
However, Windows/MSVC2019 still fail.
Waiting for all the builds to complete to have a full report and better analyse logs.

@stefano-p stefano-p changed the title Fix type size mismatches for MinGW and MSVC builds Fix type size mismatches for MinGW builds Aug 16, 2025
@stefano-p
Copy link
Contributor Author

stefano-p commented Aug 16, 2025

Build Issues Fix

MinGW builds fixed! All MinGW compilation errors have been resolved.

MSVC2019_latest. The installation of Visual Studio 2019 fails.
MSVC2019 macro issue identified: The remaining failures appear to be related to the variadic macro system (FIXED2_CHOOSER) not working correctly on MSVC2019. The macro expansion for CHECK_EQ(a,b) incorrectly results in CHECK_EQ_() with no arguments, causing cascading compilation errors.

This issue was likely introduced with the variadic macro improvements in PR #40.
The MSVC2019 preprocessor seems to handle the macro argument counting differently than other compilers.

Should we investigate the MSVC2019 compatibility of the GET_64TH_ARG and MACRO_CHOOSER system, or would you prefer a different approach?

@stefano-p
Copy link
Contributor Author

There is something wrong with some workflows. For example, MSVC2017 (Release, Win32) is endlessly running and is blocking all the others.

@jasmcaus jasmcaus merged commit 9a6f88f into jasmcaus:dev Aug 18, 2025
13 of 87 checks passed
@stefano-p stefano-p deleted the fix/static-assertion-failures branch August 18, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants