Adapt to https://github.com/math-comp/math-comp/pull/1456#1428
Merged
vbgl merged 1 commit intojasmin-lang:mainfrom Apr 7, 2026
Merged
Adapt to https://github.com/math-comp/math-comp/pull/1456#1428vbgl merged 1 commit intojasmin-lang:mainfrom
vbgl merged 1 commit intojasmin-lang:mainfrom
Conversation
21 tasks
Member
|
Thanks. Unfortunately, the proposed fix does not seem compatible with the versions that are currently in use. |
Contributor
Author
|
Indeed, thanks for pointing it. Apparently being less subtle works (CI green both here and on the upstream PR). |
vbgl
approved these changes
Apr 7, 2026
Contributor
Author
|
Thanks |
Member
|
The failing call to |
Merged
Contributor
Author
|
I guess, at worst, the two branches of the |
Contributor
|
Thanks for the suggestion! Actually, since in the meantime we moved the lower bound to Rocq 9.0, we can try your original patch. Tested here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to math-comp/math-comp#1456 (when requiring the version of mathcomp including it, this will enable to get rid of the algebra-tactics dependency).