Add --configtest argument and service#2
Open
gissf1 wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding support for my hardware, I realized that I don't want to manage long running logs and ensuring the service stays running. So I aimed to create a systemd service file to run it.
While doing this, I realized that if the configuration file every failed to parse, I wouldn't necessarily know, so I added a configuration validation flag (
--configtest) as well. The service uses this before starting to ensure the configuration is sane. If run on the command line, this will show a message explaining why the configuration failed to parse. It also returns an exit code of Zero on success, or 1 on any failure.