Adding embeddable cards in a backward compatible way.#91
Adding embeddable cards in a backward compatible way.#91vavdoshka wants to merge 3 commits intojasonwilliams:mainfrom
Conversation
…ng the scope of the processing to the content between <!-- BEGIN_ANKI_CARDS --> and <!-- END_ANKI_CARDS --> comments.
|
Hey @vavdoshka thanks for this PR, looks good. I’ll try and take a proper look |
|
I just updated the logic slightly. |
vavdoshka
force-pushed
the
feat/embeded_cards
branch
from
5f5813b to
42929da
Compare
|
Hey @vavdoshka, Implementation looks good, it may be worth adding a test here or here |
| private extractMarkedText(content: string): string { | ||
| // extract the text between markers - markdown comments <!-- BEGIN_ANKI_CARDS --> text <!-- END_ANKI_CARDS --> | ||
| // if the markers are not present then return the entire content | ||
| // Extract the text between markers - markdown comments <!-- BEGIN_ANKI_CARDS --> text <!-- END_ANKI_CARDS --> |
There was a problem hiding this comment.
Could you move these comments above the function using /** */ syntax?
its just so then you would get the function description when hovering over the symbol
There was a problem hiding this comment.
Okay, cool, thanks. I'll do it as soon as I can.
Yes, I am also planning to add an action (command) to start the embedded Anki card, which will paste the markers under a cursor and move the cursor inside the quotes.
<!-- BEGIN_ANKI_CARDS -->
|
<!-- END_ANKI_CARDS -->Any suggestions for the naming of that action? Thought of Anki: Start Embedded Cards.
There was a problem hiding this comment.
Anki: Start Embedded Cards
Should this be offered as a snippet instead? It looks more like a snippet than a full-on-command. I think the extension can contribute snippets
|
Pings @vavdoshka are you still active on this? |
2 participants
Added embeddable cards in a backward-compatible way. Allows limiting the scope of the processing to the content between
<!-- BEGIN_ANKI_CARDS -->and<!-- END_ANKI_CARDS -->comments.I found it helpful to embed the Anki Cards definitions into documents with some knowledge base data.
This change is backward compatible and should work with all the existing features from how far I've tested.