Skip to content

Inject translated module name into download url as <url>#t=<name> - #146

Merged
sverhoeven merged 4 commits into
mainfrom
human-installing-name
Apr 17, 2026
Merged

Inject translated module name into download url as <url>#t=<name>#146
sverhoeven merged 4 commits into
mainfrom
human-installing-name

Conversation

@sverhoeven

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

Coverage Report for Unit test coverage

Status Category Percentage Covered / Total
🔵 Lines 79.22% 473 / 597
🔵 Statements 79.27% 482 / 608
🔵 Functions 82.88% 92 / 111
🔵 Branches 72.55% 275 / 379
File CoverageNo changed files found.
Generated in workflow #345 for commit c6cd38d by the Vitest Coverage Report Action

@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

Coverage Report for Browser test coverage

Status Category Percentage Covered / Total
🔵 Lines 67.29% 675 / 1003
🔵 Statements 64.37% 954 / 1482
🔵 Functions 67.24% 117 / 174
🔵 Branches 61.1% 743 / 1216
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/App.tsx 79.25% 67.85% 93.15% 88.3% 60-63, 75, 78, 80, 122, 131, 131, 132, 133, 187, 189, 231, 237, 267-281, 316, 319, 322, 348, 350, 355, 356, 377, 379, 382, 398, 407, 411-431, 452, 455, 458, 460-462, 465-467, 472, 477, 479-480, 499, 507, 510, 519, 524, 525, 531-530, 549-548, 574, 578, 580-581, 592, 608, 612, 619, 620, 622, 630, 630, 631, 632, 633, 636, 667, 668, 670, 692, 693, 705-706, 721, 721, 722, 738, 739, 886, 913-916, 954-955, 964, 975, 977, 990-991, 997, 1021, 1036, 1047, 1108-1109, 1151, 1152, 1164, 1166, 1167, 1170, 1171, 1094-1095, 1282, 1285
Generated in workflow #345 for commit c6cd38d by the Vitest Coverage Report Action

@sverhoeven

Copy link
Copy Markdown
Contributor Author

Tested with JASP 0.96 Windows pointing to module app running locally and hash in download url is ignored. So app can be deployed and will not break existing usage.

Same as how it is parsed in the jasp-desktop
@sverhoeven
sverhoeven merged commit 7a858b2 into main Apr 17, 2026
5 checks passed
@sverhoeven
sverhoeven deleted the human-installing-name branch April 17, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant