Skip to content

Recurse submodules only one level. - #148

Merged
sverhoeven merged 2 commits into
mainfrom
no-nested-submodules
Apr 20, 2026
Merged

Recurse submodules only one level.#148
sverhoeven merged 2 commits into
mainfrom
no-nested-submodules

Conversation

@sverhoeven

@sverhoeven sverhoeven commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Ignores any submodules in module repos like
jaspModuleTemplate in
https://github.com/egonzato/jaspPropensityScoreMethods/tree/main/inst/qml

Before

Cloning into '/home/verhoes/git/JASP-MOD/modules-app/registry/Official/jaspVisualModeling'...
fatal: No url found for submodule path 'Community/jaspPropensityScoreMethods/inst/qml/jaspModuleTemplate' in .gitmodules
fatal: Failed to recurse into submodule path 'Community/jaspPropensityScoreMethods'

    at Object.action (file:///home/verhoes/git/JASP-MOD/modules-app/node_modules/.pnpm/simple-git@3.30.0/node_modules/simple-git/dist/esm/index.js:4462:25)
    at PluginStore.exec (file:///home/verhoes/git/JASP-MOD/modules-app/node_modules/.pnpm/simple-git@3.30.0/node_modules/simple-git/dist/esm/index.js:4501:25)
    at file:///home/verhoes/git/JASP-MOD/modules-app/node_modules/.pnpm/simple-git@3.30.0/node_modules/simple-git/dist/esm/index.js:1345:43
    at new Promise (<anonymous>)
    at GitExecutorChain.handleTaskData (file:///home/verhoes/git/JASP-MOD/modules-app/node_modules/.pnpm/simple-git@3.30.0/node_modules/simple-git/dist/esm/index.js:1343:16)
    at GitExecutorChain.attemptRemoteTask (file:///home/verhoes/git/JASP-MOD/modules-app/node_modules/.pnpm/simple-git@3.30.0/node_modules/simple-git/dist/esm/index.js:1330:42)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async GitExecutorChain.attemptTask (file:///home/verhoes/git/JASP-MOD/modules-app/node_modules/.pnpm/simple-git@3.30.0/node_modules/simple-git/dist/esm/index.js:1302:18) {
  task: {
    commands: [
      'clone',
      '--depth',
      '1',
      '--recurse-submodules',
      '--branch',
      'main',
      'https://github.com/jasp-stats-modules/modules-registry.git',
      '/home/verhoes/git/JASP-MOD/modules-app/registry'
    ],
    format: 'utf-8',
    parser: [Function: parser]
  }
}

@github-actions

github-actions Bot commented Apr 20, 2026

Copy link
Copy Markdown

Coverage Report for Unit test coverage

Status Category Percentage Covered / Total
🔵 Lines 78.96% 473 / 599
🔵 Statements 79.01% 482 / 610
🔵 Functions 82.88% 92 / 111
🔵 Branches 72.55% 275 / 379
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/scrape.ts 80.91% 80.78% 80.95% 81.05% 38-41, 83-125, 279-280, 286-287, 300, 310, 328, 399-400, 433, 439, 443, 482, 489, 495-506, 515, 539-542, 692, 702, 707-709, 799-837, 882, 1012-1014, 1040-1042, 1247-1251, 1296, 1339-1358, 1363-1365
Generated in workflow #348 for commit 284b1d0 by the Vitest Coverage Report Action

@github-actions

github-actions Bot commented Apr 20, 2026

Copy link
Copy Markdown

Coverage Report for Browser test coverage

Status Category Percentage Covered / Total
🔵 Lines 67.29% 675 / 1003
🔵 Statements 64.37% 954 / 1482
🔵 Functions 67.24% 117 / 174
🔵 Branches 61.1% 743 / 1216
File CoverageNo changed files found.
Generated in workflow #348 for commit 284b1d0 by the Vitest Coverage Report Action

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the registry scraping flow to avoid failing on nested submodules inside module repositories by only updating top-level submodules of the modules-registry repo.

Changes:

  • Stop using --recurse-submodules during git clone and git pull of the modules registry.
  • Explicitly run a separate git submodule update --init step (non-recursive) to fetch only top-level registry submodules.
  • Refresh public/index.json with the newly scraped registry/release data.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
src/scrape.ts Adjusts git clone/pull flags and adds an explicit top-level git submodule update step to avoid nested-submodule recursion failures.
public/index.json Updated generated registry index output (modules/releases/assets metadata).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sverhoeven
sverhoeven merged commit 00f7b19 into main Apr 20, 2026
9 checks passed
@sverhoeven
sverhoeven deleted the no-nested-submodules branch April 20, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants