Fix decoding of Patchwork plots for ggplot2 > 4.0.0

[vandenman]

Fixes jasp-stats/jasp-issues#4126

@matyasbukva do you know how to test this in descriptives with custom version of jaspBase? If not, just let me know and I can ask someone else to review.

[vandenman]

macOS failure is unrelated.

[vandenman]

@juliuspfadt would you have time to review? Refreshing the jasp file in the issue should be enough to verify the fix.

[juliuspfadt]

I can do it, but I am also not so sure how. I am not building JASP so I dont know how I would do this.

[vandenman]

To test, you can:

1. open jaspDescriptives inside RStudio (make sure the renv project is activated).
2. renv::install("vandenman/jaspBase@decodeplot_patchwork")
3. build jaspDescriptives as usual, make sure jaspBase it not "updated" somehow.
4. refresh the jasp file in jasp (it's not possible to verify this with jaspTools).

[juliuspfadt]

thats what I did already....
but with, which has not resolved the issue

renv::install("vandenman/jaspBase@f8efc7b6b936daca4438725d175398f010bf9bc4")
library(jaspModuleTools)
renv::install('.', prompt = FALSE); prepare_for_jasp_loading()

[matyasbukva]

@vandenman @juliuspfadt
Now that you've written it down, I was able to do it too. :'D... I could have asked for this...
so: it works! Fantastic. BUT ONLY if the jasp theme is not set. Something is wrong with that theme setting. If it is set, it's as if the ggplot object is not extracted from the tidyplot object, but the script continues to work with it. Something doesn't work if jasp is the selected plot design. But otherwise, everything else is okay.
iris.zip

[juliuspfadt]

can you give your review then?

[matyasbukva]

the fix works, but not for the plot legend. can you fix that please?

[EJWagenmakers]

Guys I am teaching a workshop on data visualization tomorrow (Thursday) at 14:00. It would be great to see this merged -- in that case I can upload the beta and use the JASP settings for the Plot Builder, right?

[matyasbukva]

I've sent a pull request that fixes the sizing issue, so I think it's possible