Rename Z bench

[Kucharssim]

fixes https://github.com/jasp-stats/external-issues/issues/12

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.01%. Comparing base (0d963d0) to head (52ccb89).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   85.00%   85.01%   +0.01%     
==========================================
  Files          18       18              
  Lines        9916     9924       +8     
==========================================
+ Hits         8429     8437       +8     
  Misses       1487     1487              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[JTPetter]

@Kucharssim Minor changes, so I only have one remark, maybe remove the mention of other software from the comment in the tests, we will do that throughout the module soon. Let's see if copilot has anything to add :)

[JTPetter]

Okay, I just did it myself, didn't know I could

[Copilot]

Pull request overview

Renames the “Z bench” option/column in the Process Capability Studies analysis to a clearer “Z (ST) / Z (LT)” naming, with upgrade support for existing .jasp files and accompanying UI/help/test updates.

Changes:

• Rename option processCapabilityTableZbench → processCapabilityTableZ (with inst/Upgrades.qml migration).
• Rename output columns from zbench to zSt / zLt and update table headers.
• Update QML label, help text, tests, and bump package version to 0.96.1.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/testthat/test-processCapabilityStudies.R	Updates test option key to the renamed processCapabilityTableZ.
R/processCapabilityStudies.R	Renames Z-related option/columns and table column headers for ST/LT.
inst/Upgrades.qml	Adds migration to rename the stored option key in existing files.
inst/qml/processCapabilityStudies.qml	Renames the checkbox option and updates its label.
inst/help/processCapabilityStudies.md	Updates documentation to describe Z (ST) and Z (LT).
DESCRIPTION	Bumps module version to 0.96.1.

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Renames the “Z bench” option in the Process Capability Studies analysis to a clearer “Z (ST) / Z (LT)” label and updates the corresponding option key across UI, backend, tests, docs, and upgrade migration.

Changes:

• Renamed option key processCapabilityTableZbench → processCapabilityTableZ across QML, R, and tests; added upgrade migration for backward compatibility.
• Renamed output columns from zbench to zSt / zLt and updated help text to explain Z (ST) and Z (LT).
• Bumped package version to 0.96.1.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
R/processCapabilityStudies.R	Renames Z column(s) and option check in capability/performance tables.
inst/qml/processCapabilityStudies.qml	Renames the checkbox option and updates its label to “Z (ST) / Z (LT)”.
inst/Upgrades.qml	Adds migration rule to rename the stored option key for existing .jasp files.
tests/testthat/test-processCapabilityStudies.R	Updates test options to use the new option name.
inst/help/processCapabilityStudies.md	Updates documentation to define Z (ST) and Z (LT).
DESCRIPTION	Version bump to 0.96.1.

[juliuspfadt]

Some of the copilot comments seem to make sense to me. what do you think @Kucharssim?

[Kucharssim]

I am not sure about the sourceVector stuff, perhaps @JTPetter knows whether it is necessary to include the Z stat in there?

Otherwise, I think Copilot's claim that the code will error out with rbind(tableDf, tableDfCurrentStage) is false, since tableDf is empty at construction, so it will just inherit whatever columns are in tableDfCurrentStage. I am also unable to produce this error even with multiple stages in the analysis. I am missing something here?

[juliuspfadt]

all good then. I didnt look at it, but if Jonas did should be fine

too early

[JTPetter]

@Kucharssim Hmm I think in previous versions of R you could not use rbind if the number of columns did not match. Even if it the table to bind to had 0 rows. That is why it is initialized as

tableDf <- data.frame(matrix(ncol = length(tableColNames), nrow = 0))

But I can confirm that it is possible now.

However, I actually noticed that the Z bench values are not added to the report. This is because they are not passed in the data frame that is returned using the "returnDataframe" or "returnOverallCapDataframe" arguments in the respective functions. Could you add the Z bench statistics to this dataframe? Lines 1227+ and 1468+. When you do that, you also need to add the Z statistics to the sourceVector, because that where the names for this df are defined.

[JTPetter]

And if you could add a quick unit tests of a report that includes the z statistics that would be even better :)

[Kucharssim]

Okay, will do! Thanks :)