[jaspRegression] Change default model prior from beta-binomial to uniform in...#483
Open
sisyphus-jasp wants to merge 1 commit intojasp-stats:masterfrom
Open
[jaspRegression] Change default model prior from beta-binomial to uniform in...#483sisyphus-jasp wants to merge 1 commit intojasp-stats:masterfrom
sisyphus-jasp wants to merge 1 commit intojasp-stats:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
==========================================
- Coverage 75.91% 75.90% -0.02%
==========================================
Files 21 21
Lines 8384 8392 +8
==========================================
+ Hits 6365 6370 +5
- Misses 2019 2022 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: https://github.com/jasp-stats/INTERNAL-jasp/issues/2922
Root cause
Bayesian regression defaults still pointed to
betaBinomial(wrapper args + QML default), notuniform. Also no uniform-specific model-size footnote in model comparison output.What changed
modelPriortouniformin:R/regressionlinearbayesianWrapper.RR/regressionlogisticbayesianWrapper.Rinst/qml/RegressionLinearBayesian.qmlinst/qml/RegressionLogisticBayesian.qmlR/regressionlinearbayesian.RR/regressionlogisticbayesian.RVerification
testAll()result:[ FAIL 0 | WARN 58 | SKIP 1 | PASS 594 ].uniformbetaBinomialCaveats
Implementation Plan
Root cause
betaBinomialin both UI (inst/qml/RegressionLinearBayesian.qml,inst/qml/RegressionLogisticBayesian.qml) and wrappers (R/regressionlinearbayesianWrapper.R,R/regressionlogisticbayesianWrapper.R).wilsonandcastillo; no explanatory footnote is shown foruniforminR/regressionlinearbayesian.RandR/regressionlogisticbayesian.R.Proposed changes
uniform:checked: truefrombetaBinomialtouniform.modelPrior = "betaBinomial"tomodelPrior = "uniform".uniforminstead ofbetaBinomial.R/regressionlinearbayesian.Rin.basregTableModelComparison().R/regressionlogisticbayesian.Rin.bayesianLogisticRegTableModelComparison().Expected test impact
options$modelPrior, so broad regression risk is low.modelPrior == "uniform"; this may affect tests that inspect that output for uniform settings.Change default model prior from beta-binomial to uniform in regression analysis and add explanatory footnote about model size benefits
Test Results
Automated Code Review
Approved after 1 review iteration(s).