Skip to content

proper e-notation equation table#484

Merged
JohnnyDoorn merged 16 commits intojasp-stats:masterfrom
JohnnyDoorn:fix-equation-e-notation
Apr 2, 2026
Merged

proper e-notation equation table#484
JohnnyDoorn merged 16 commits intojasp-stats:masterfrom
JohnnyDoorn:fix-equation-e-notation

Conversation

@JohnnyDoorn
Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings March 25, 2026 14:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates regression equation coefficient formatting to handle scientific notation more appropriately (issue #7), and adjusts example-based tests/snapshots accordingly.

Changes:

  • Format regression equation coefficients via a new helper instead of round().
  • Split the “Exam Anxiety” example test to target specific analyses and add a regression test.
  • Add new SVG snapshot outputs for the Titanic example.

Reviewed changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated 3 comments.

File Description
tests/testthat/test-example-Exam Anxiety.R Selects specific analyses from the example file and adds coverage for RegressionLinear outputs.
tests/testthat/_snaps/example-Titanic/analysis-1-figure-3-jaspcolumn3.new.svg Adds a new/updated snapshot output for Titanic example figure 3.
tests/testthat/_snaps/example-Titanic/analysis-1-figure-2-jaspcolumn1.new.svg Adds a new/updated snapshot output for Titanic example figure 2.
R/regressionlinear.R Introduces .formatCoefEquation() and uses it for equation-table coefficient formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread R/regressionlinear.R
Comment thread R/regressionlinear.R
Comment thread tests/testthat/test-example-Exam Anxiety.R
@juliuspfadt juliuspfadt self-requested a review March 25, 2026 16:49
Copy link
Copy Markdown

@juliuspfadt juliuspfadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! issue is fixed. after the tests, this can be merged :)

@JohnnyDoorn JohnnyDoorn merged commit 1572c9b into jasp-stats:master Apr 2, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants