proper e-notation equation table#484
Merged
JohnnyDoorn merged 16 commits intojasp-stats:masterfrom Apr 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates regression equation coefficient formatting to handle scientific notation more appropriately (issue #7), and adjusts example-based tests/snapshots accordingly.
Changes:
- Format regression equation coefficients via a new helper instead of
round(). - Split the “Exam Anxiety” example test to target specific analyses and add a regression test.
- Add new SVG snapshot outputs for the Titanic example.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/testthat/test-example-Exam Anxiety.R | Selects specific analyses from the example file and adds coverage for RegressionLinear outputs. |
| tests/testthat/_snaps/example-Titanic/analysis-1-figure-3-jaspcolumn3.new.svg | Adds a new/updated snapshot output for Titanic example figure 3. |
| tests/testthat/_snaps/example-Titanic/analysis-1-figure-2-jaspcolumn1.new.svg | Adds a new/updated snapshot output for Titanic example figure 2. |
| R/regressionlinear.R | Introduces .formatCoefEquation() and uses it for equation-table coefficient formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
juliuspfadt
approved these changes
Mar 25, 2026
juliuspfadt
left a comment
There was a problem hiding this comment.
Nice! issue is fixed. after the tests, this can be merged :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/jasp-stats/external-issues/issues/7