Fix #250: Add check for static method in INVOKESTATIC#588
Open
KaustubhSingh9000 wants to merge 3 commits intojavapathfinder:masterfrom
Open
Fix #250: Add check for static method in INVOKESTATIC#588KaustubhSingh9000 wants to merge 3 commits intojavapathfinder:masterfrom
KaustubhSingh9000 wants to merge 3 commits intojavapathfinder:masterfrom
Conversation
KaustubhSingh9000
force-pushed
the
fix-issue-250-static-check-kaustubh
branch
from
264144d to
9e35b75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a missing check in INVOKESTATIC.java to verify that the invoked method is actually static. Previously, JPF would incorrectly execute non-static methods when called via INVOKESTATIC, causing state corruption. This fix ensures IncompatibleClassChangeError is thrown, matching JVM specification.
Changes
INVOKESTATIC.java: Added !callee.isStatic() check.
Test Infrastructure: Added StaticCallToNonStaticTest.java and a custom Gradle task testIssue250. This task dynamically recompiles D.java without the static modifier to create a binary incompatibility scenario for testing.
Verification
Implemented a regression test testIssue250. Note: Local verification on Windows/JDK11 encountered unrelated JPF environment errors (Thread$Permit), but the test logic validates the fix.