fix: remove duplicate isSealed and permittedSubclassNames fields from JVMClassInfo#607
Open
Himaswin wants to merge 2 commits intojavapathfinder:java-17from
Open
fix: remove duplicate isSealed and permittedSubclassNames fields from JVMClassInfo#607Himaswin wants to merge 2 commits intojavapathfinder:java-17from
Himaswin wants to merge 2 commits intojavapathfinder:java-17from
Conversation
Contributor
|
Hi Himaswin, |
Author
|
Hi Mahmoud,
Thanks for the suggestion. I’ll try to add tests for isSealed and
isPermittedSubclass() to verify that parsing the .class file correctly
populates those fields. I’ll reach out if I have any doubts, if that’s okay.
…On Sun, Mar 8, 2026 at 8:13 PM Mahmoud Khawaja ***@***.***> wrote:
*Mahmoud-Khawaja* left a comment (javapathfinder/jpf-core#607)
<#607 (comment)>
Hi Himaswin,
Thank you for your pull request. can you please add some tests? maybe
something to test isSealed or isPermittedSubclass(). we need to check
that parsing a .class file correctly populates isSealed and
permittedSubclassNames. this is gonna be a little bit hard i know but i
dont think there is a way to do it other than this.
—
Reply to this email directly, view it on GitHub
<#607 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2DUBY4IJKWZLAXBOLFPZBD4PYEC3AVCNFSM6AAAAACWITZDVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAMRQGMZTIMJRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #605
Removed duplicate
isSealedandpermittedSubclassNamesfield declarationsfrom JVMClassInfo as they already exist in parent class ClassInfo.