Skip to content

fix: remove duplicate isSealed and permittedSubclassNames fields from JVMClassInfo#607

Open
Himaswin wants to merge 2 commits intojavapathfinder:java-17from
Himaswin:fix/remove-duplicate-sealed-fields
Open

fix: remove duplicate isSealed and permittedSubclassNames fields from JVMClassInfo#607
Himaswin wants to merge 2 commits intojavapathfinder:java-17from
Himaswin:fix/remove-duplicate-sealed-fields

Conversation

@Himaswin
Copy link
Copy Markdown

@Himaswin Himaswin commented Mar 5, 2026

Fixes #605

Removed duplicate isSealed and permittedSubclassNames field declarations
from JVMClassInfo as they already exist in parent class ClassInfo.

@Mahmoud-Khawaja
Copy link
Copy Markdown
Contributor

Hi Himaswin,
Thank you for your pull request. can you please add some tests? maybe something to test isSealed or isPermittedSubclass(). we need to check that parsing a .class file correctly populates isSealed and permittedSubclassNames. this is gonna be a little bit hard i know but i dont think there is a way to do it other than this.

@Himaswin
Copy link
Copy Markdown
Author

Himaswin commented Mar 10, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants