Open
Conversation
jayhf
reviewed
Sep 2, 2020
Owner
jayhf
left a comment
jayhf
left a comment
There was a problem hiding this comment.
This looks great. Thanks for improving the cleanup behavior!
Comment on lines
+304
to
+310
| { | ||
| if (!_alreadyLoaded) | ||
| return; | ||
|
|
||
| _alreadyLoaded = false; | ||
| OnUnloaded(sender, new RoutedEventArgs()); | ||
| }; |
Owner
There was a problem hiding this comment.
This event handler can be moved to an inner function that's shared with the Unloaded event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenTK reference has been upgraded.
Added a cleanup event that it's called when the current OpenGL context it's about to get destroyed. That gives a chance to the application to free any unmanaged resources that requires the OpenGL context to be active (like texture handlers, vbos, etc)
The unloaded event it's not called if the control it's destroyed due to the application shutting down. To prevent any issues or even memory leaks (because of unmanaged resources dependent on the OpenGL's context) the control suscribes to the current application's shutdown event to release all the unmanaged resources and raise the cleanup event, so all the system can be stopped gracefully and the application has always a chance to release unmanaged resources if needed.