create pyproject.toml to guarantee pypandoc is installed before setup.py executes#2
Open
ddurdik wants to merge 4 commits intojazzycamel:masterfrom
Open
create pyproject.toml to guarantee pypandoc is installed before setup.py executes#2ddurdik wants to merge 4 commits intojazzycamel:masterfrom
ddurdik wants to merge 4 commits intojazzycamel:masterfrom
Conversation
When pip installing directly from master branch, pip runs setup.py install before it installs things from the requirements file. This causes an import error because pypandoc hasn't been installed yet (since it's in requirements). This PR fixes that by deferring the pypandoc import until after it's installed.
This reverts commit 409fdbe.
pypandoc isn't available on all Linux distros (e.g. alpine), which means pushy doesn't work on those distros. It doesn't seem reasonable to gate usage of pushy on generating nice docs, so I removed pypandoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pip installing directly from master throws an error because setup.py requires pypandoc, but pypandoc hasn't been installed from requirements yet. Putting pypandoc in pyproject.toml guarantees that pypandoc will get installed before setup.py executes.
Sorry for the messy history, please feel free to squash!