Skip to content

Add support for beancount v3#256

Open
LalitMaganti wants to merge 2 commits into
jbms:masterfrom
LalitMaganti:master
Open

Add support for beancount v3#256
LalitMaganti wants to merge 2 commits into
jbms:masterfrom
LalitMaganti:master

Conversation

@LalitMaganti
Copy link
Copy Markdown

Switch to using beangulp which supports both v2 and v3.

Fixes: #253

Switch to using beangulp which supports both v2 and v3.
@Nulifier
Copy link
Copy Markdown

Nulifier commented Jan 9, 2026

This doesn't appear to work for the generic_importer_source.

I get the following error:

TypeError: expected str, bytes or os.PathLike object, not _FileMemo

This is related to the switch from _FileMemo to straight filepath strings. I managed to get past that by checking if the filepath has a name property and using that. When I got past that, I ran into the following issue:

TypeError: Importer.extract() got an unexpected keyword argument 'existing_entries' which is related to the change in call signature from the Importer.

@LalitMaganti
Copy link
Copy Markdown
Author

Thanks for letting me know. 0c37757 should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beangulp compatible?

2 participants