Journal entry filename should have bean in name#63
Closed
dumbPy wants to merge 1 commit into
Closed
Conversation
beancount.ingest.importer.ImporterProtocol based importers add filename to each transaction. Hence they are classified as journal entry too Since journal has bean/beancount extension, that can be an added filter
Pull Request Test Coverage Report for Build 145
💛 - Coveralls |
Owner
|
I think it might be better to just strip off the filename metadata when passing the entries to beancount-import, since there isn't really a standard filename extension for beancount. |
Contributor
Author
|
Handled in ImporterSource #62 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing conversation from here
beancount.ingest.importer.ImporterProtocolbased importers addfilenameto meta of each transaction.Hence they are being classified as journal entry too.
This causes the beancount-import to pick Imported entry's narration over manually entered transaction's narration.
Since journal has
.bean/.beancountextension, that can be an added filter. Statement names almost never contain the wordbean.Tested.