Namespace mochijson2 to avoid collision with mochiweb#23
Closed
opsb wants to merge 1 commit intojbrisbin:masterfrom
Closed
Namespace mochijson2 to avoid collision with mochiweb#23opsb wants to merge 1 commit intojbrisbin:masterfrom
opsb wants to merge 1 commit intojbrisbin:masterfrom
Conversation
Author
|
just spotted that it's a dupe of #13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit a collision when using https://github.com/pma/amqp and https://github.com/philss/floki in the same project. floki relies on https://github.com/mochi/mochiweb which obviously has it's own copy of mochijson2. When performing a distillery release it fails due to the duplicated modules.
This PR resolves the issue by namespacing the mochijson2 module as rabbit_common_mochijson2