Allow symfony/var-exporter in version 8#33
Allow symfony/var-exporter in version 8#33mburtscher wants to merge 1 commit intojbtronics:masterfrom
Conversation
|
Have you tried out if it works fine with var-exporter 8? I had explicitly removed it from composer.json: 38e3416 the tests fail, because it removed the old lazy ghost creation logic. In principle that is not necessarily, as the bundle can use the modern PHP8.4 style lf available. For BC reasons it still have references to the old versions... |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
============================================
- Coverage 88.95% 88.32% -0.64%
Complexity 562 562
============================================
Files 47 47
Lines 1449 1439 -10
============================================
- Hits 1289 1271 -18
- Misses 160 168 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jbtronics Oh sorry, I did not realize that this was a concious decision. I was wondering about the reason since I use my fork successfully in a Symfony 8 project - but in this case with PHP 8.4 which prevents var-exporter from being used if I understand correctly. However, the version constraint actually makes it unusable if symfony/var-exporter is required in a Symfony 8 project. Not sure how to handle that correctly: Either symfony/var-exporter 6/7 OR PHP 8.4+ 🤔 |
|
Fixed in PR #34 |
Right now, you can't install the package with Symfony 8 since it requires symfony/var-exporter in version 6 or 7.