Skip to content

Allow symfony/var-exporter in version 8#33

Closed
mburtscher wants to merge 1 commit intojbtronics:masterfrom
mburtscher:fix-symfony-8
Closed

Allow symfony/var-exporter in version 8#33
mburtscher wants to merge 1 commit intojbtronics:masterfrom
mburtscher:fix-symfony-8

Conversation

@mburtscher
Copy link

Right now, you can't install the package with Symfony 8 since it requires symfony/var-exporter in version 6 or 7.

@jbtronics
Copy link
Owner

Have you tried out if it works fine with var-exporter 8?

I had explicitly removed it from composer.json: 38e3416

the tests fail, because it removed the old lazy ghost creation logic. In principle that is not necessarily, as the bundle can use the modern PHP8.4 style lf available. For BC reasons it still have references to the old versions...

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.32%. Comparing base (6a66c09) to head (1c457a9).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #33      +/-   ##
============================================
- Coverage     88.95%   88.32%   -0.64%     
  Complexity      562      562              
============================================
  Files            47       47              
  Lines          1449     1439      -10     
============================================
- Hits           1289     1271      -18     
- Misses          160      168       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mburtscher
Copy link
Author

mburtscher commented Feb 25, 2026

@jbtronics Oh sorry, I did not realize that this was a concious decision. I was wondering about the reason since I use my fork successfully in a Symfony 8 project - but in this case with PHP 8.4 which prevents var-exporter from being used if I understand correctly.

However, the version constraint actually makes it unusable if symfony/var-exporter is required in a Symfony 8 project.

Not sure how to handle that correctly: Either symfony/var-exporter 6/7 OR PHP 8.4+ 🤔

@jbtronics
Copy link
Owner

Fixed in PR #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants