Add longitude_bnds and latitude_bnds to cmip_renaming_dict

[JoranAngevaare]

Add longitude_bnds and latitude_bnds to cmip_renaming_dict, this allows renaming for example renaming bounds for 'ScenarioMIP.UA.MCM-UA-1-0.ssp585.r1i1p1f2.Amon.gn.none.tas' .

• Tests added
• Passes pre-commit run --all-files
• Passes pytest
• User visible changes (including notable bug fixes) are documented in whats-new.rst

[jbusecke]

Thank you very much for adding these @JoranAngevaare.
I think the testing failure is unrelated (looks like #301). Let me take a crack at that and see if that resolves the CI failures here.
Sorry for the delay.

[jbusecke]

Ok I am fairly confident that the above issue is fixed by jbusecke/xarrayutils#162, since the upstream-dev tests are now passing. Once v2.0.0 is published on conda-forge I expect the other tests to pass.

[jbusecke]

Ok I got it all sorted. Thanks for your patience @JoranAngevaare.
Would you mind adding an entry to the docs/whats-new.rst? Once that is done, ill merge this right away!

[JoranAngevaare]

@jbusecke thanks a lot for all the fixes! I see that numpy 1.24.0 drop of deprecated np.float caused some issues, the np.zeros(.., float) will be interpreted as np.zeros(.., np.float64)'s which would also have solved that particular problem.

I added a trivial test eff95dc, however, that lead me to notice that bnds is renamed to bnds, I'm not entirely sure if that is a desirable feature. If so, I'll very quickly revert a6a5835.

[jbusecke]

that lead me to notice that bnds is renamed to bnds

I am not sure I follow this. I do intent to rename the bounds dimension similarly to others, but I might be missing something in your comment.

[JoranAngevaare]

@jbusecke this is the line I mentioned, so from the cmip6_renaming_dict, you were renaming bnds to bnds. But okay, I'll revert a6a5835 - maybe that is safer.

[jbusecke]

Hi @JoranAngevaare again sorry for the delay (the amount of times I have typed this today 😆). I am not quite following myself from the past TBH. I now completely agree that renaming "bnds" to "bnds" is nonsensical. Sorry for the back and forth. Could you restore that change? Ill get this moving right after the tests pass.

[jbusecke]

I would also like to add you to the CITATION.cff for the contributions you made here.

[jbusecke]

@JoranAngevaare finally getting around to merging this. Again sorry for the delay. I have opened #358 to track the addition to the CITATION file.

[JoranAngevaare]

hi @jbusecke sorry for the delay on my side - I missed these previous comments.