This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Change int type for SCNotification Scintilla#268
Merged
jcaillon merged 1 commit intojcaillon:masterfrom Dec 16, 2019
Merged
Conversation
Owner
|
Hello @thony8 ! thank you so much for this MR ;) I am gladly accepting it without prior testing, as it seems to make a lot of sense judging by the scintillaNET changes you linked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to jacobslusser/ScintillaNET#447, a change in several integer variables causes nc.modificationType equals to 0 (due to Scintilla updates). This result causes a behavior problem in the NotificationPublisher.cs (case SCN_MODIFIED).
This problem appears only in 64-bits Notepad++ 7.7 and above and related to #263 .