Open
Conversation
Which meant filling in some blanks and changing some namespace. added meancat blurb about version changes and how the docs might be out of date GluW repository information a version that works with jetty 9.2.10
…tract Session class from the jetty 8 implementation
SessionSkeleton extends MemSession not AbstractSession (MemSession didn't exist in Jetty 9.1)
Removed meancat.com reference and reset pom back to the original groupId, SCM, etc. Deleted accidentally added pom.xml.versionsBackup Hey, extra blank line added to SessionManagerSkeleton, got rid of that.
This class calls jedis.exists() to determine if a session key has expired or not - but was comparing the return value vs. 0L instead of vs. a boolean false, so RedisSessions would never be scavenged, leaking resources. See: ovea-deprecated#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified some dependencies in jcern/jetty-session-redis to work with some libraries on a project, including upgrading to Jetty 9.2.