Merged
Conversation
✅ Deploy Preview for getcvdev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Adjusted spacing in technical skills
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on improving spacing/typographic consistency in the “Jake’s Resume” template, including date-range formatting and layout tweaks, and introduces a dedicated preview route for viewing the template.
Changes:
- Update period formatting to use an en-dash separator for date ranges.
- Adjust resume template CSS/markup to standardize line-height and section spacing.
- Add a new
/editor/previewroute andPreviewpage to render the resume template.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils/formatDate.ts |
Changes date period separator from hyphen to en-dash. |
src/templates/jakesResume.css |
Adds global box-sizing/line-height rules and changes section title underline styling. |
src/templates/JakesResume.tsx |
Refactors spacing/layout for header, sections, and list items; updates line-height usage. |
src/pages/Preview.tsx |
New preview page rendering JakesResume from stored CV data. |
src/main.tsx |
Adds route for the new preview page. |
src/data/initialCv.json |
Adds a whitespace-only line change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/templates/jakesResume.css
Outdated
Comment on lines
+29
to
+31
| * { | ||
| box-sizing: border-box !important; | ||
| line-height: 1em !important; |
src/pages/Preview.tsx
Outdated
|
|
||
| return ( | ||
| <div className="border border-red-500 w-fit mx-auto"> | ||
| <JakesResume cvData={cvData} />; |
src/pages/Preview.tsx
Outdated
| const { cvData } = useCvData(); | ||
|
|
||
| return ( | ||
| <div className="border border-red-500 w-fit mx-auto"> |
Comment on lines
+193
to
202
| <div className="flex gap-1.5"> | ||
| <strong>Programming Languages: </strong> | ||
| <span>{cvData.skills.programmingLanguages.join(", ")}</span> | ||
| </div> | ||
| )} | ||
|
|
||
| {cvData.skills.frameworks.length > 0 && ( | ||
| <div> | ||
| <div className="flex gap-1.5"> | ||
| <strong>Frameworks / Libraries: </strong> | ||
| <span>{cvData.skills.frameworks.join(", ")}</span> |
src/templates/JakesResume.tsx
Outdated
| {cvData.skills.developerTools.length > 0 && ( | ||
| <div> | ||
| <div className="flex gap-1.5"> | ||
| <strong>Developer Tools: </strong> |
src/data/initialCv.json
Outdated
Comment on lines
28
to
29
|
|
||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.