added dockerfile and update docker-compose#12
Open
yamikarajput546 wants to merge 2 commits into
Open
Conversation
Owner
|
Need to review the changes |
Author
|
@javibauza can you check it now |
jcromanu
reviewed
Feb 14, 2022
jcromanu
left a comment
jcromanu
left a comment
Owner
There was a problem hiding this comment.
why do you change port numbers ? and delete the mongo volume ?
Author
|
hey, @jcromanu I've changed the port on my local machine 8080 is used by Jenkins but if your docker-compose is working fine, you can ignore these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
please check and merge the PR
how you can check:
docker image build -t go-mysql:01 .
docker-compose build
docker-compose up -d
tell me how you're running this app
also there aren't go files anyway let me know if any issue :)