Include plaintext password in command's environment#3
Open
Gumnos wants to merge 1 commit intojcs:masterfrom
Open
Include plaintext password in command's environment#3Gumnos wants to merge 1 commit intojcs:masterfrom
Gumnos wants to merge 1 commit intojcs:masterfrom
Conversation
login_duress can also be used to perform an action when NOT under duress, allowing the system credentials to boot into an innocuous sytem, then have the "duress" password configure things normally. Notably, doing things like running `bioctl -c C` to attach a crypto volume at login via the command run by login_duress. However, to do that, `bioctl` needs a password (using a keyfile/keydisk would be an additional vulnerability, and can't be rotated like passwords can) This change should put the plaintext password in the environment so the script that login_duress runs can use it something like echo "$PASSWORD" | bioctl -c C -s -l $HOME/.vault.img mount /dev/sd1 $HOME/private/ As I understand the existing code, this command-script that login_duress runs will run to completion and exit rather than leaking the environment variables to the resulting post-login shell.
Author
|
FWIW, this stemmed from brynet@ mentioning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
login_duress can also be used to perform an action when NOT under duress, allowing the system credentials to boot into an innocuous sytem, then have the "duress" password configure things normally.
Notably, doing things like running
bioctl -c Cto attach a crypto volume at login via the command run by login_duress. However, to do that,bioctlneeds a password (using a keyfile/keydisk would be an additional vulnerability, and can't be rotated like passwords can)This change should put the plaintext password in the environment so the script that login_duress runs can use it something like
As I understand the existing code, this command-script that login_duress runs will run to completion and exit rather than leaking the environment variables to the resulting post-login shell.