fix: clear descriptorTargetMap on unmount to prevent memory leak - #1705
Open
498755303 wants to merge 2 commits into
Open
fix: clear descriptorTargetMap on unmount to prevent memory leak#1705498755303 wants to merge 2 commits into
498755303 wants to merge 2 commits into
Conversation
release version 1.0.0-rc.32
descriptorTargetMap accumulates an entry per property whose descriptor is queried through the proxy window (getOwnPropertyDescriptor), but was never cleared. Under repeated mount/unmount (keep-alive, prerender) the map grows without bound and may hold stale routing targets. Lift the map to patchWindow scope, pass it to createProxyWindow and patchWindowEffect, and clear it in release() on every unmount mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
descriptorTargetMapinsrc/sandbox/with/window.tsrecords an entry forevery property whose descriptor is queried through the proxy window
(
getOwnPropertyDescriptor), but it is never cleared.Under repeated mount/unmount (keep-alive, prerender) the map grows without
bound, and it may also hold stale routing targets across app lifecycles.
Change
descriptorTargetMapfromcreateProxyWindowto thepatchWindowscope.createProxyWindowandpatchWindowEffect.release()on unmount (outside theclearTimerbranch, so it iscleared in every unmount mode).
Notes
No behavior change for a mounted app; only frees the cache on unmount.