Skip to content

DONOTMERGE: Fix null as default in deployParams#178

Draft
jordlay wants to merge 3 commits into2.0.0b2-releasefrom
jl/change-how-null-handled
Draft

DONOTMERGE: Fix null as default in deployParams#178
jordlay wants to merge 3 commits into2.0.0b2-releasefrom
jl/change-how-null-handled

Conversation

@jordlay
Copy link
Collaborator

@jordlay jordlay commented Apr 18, 2024


Important: we have not merged this because it feels like the wrong solution. The ideal solution is to fix the bug in the RP that means that defaultValues cannot be null at the nfdv stage.

If there is a null type, the default is null. AOSM doesnt allow this at nfdv publish stage. To workaround this, we check if the default is none, and add it to required if not.

Testing Completed:

  • tested with helm chart that had a null type, it didnt add a default, and added the param to required. It also kept the defaults for all the other params
  • all the way to sns

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@jordlay jordlay requested a review from sunnycarter as a code owner April 18, 2024 09:49
Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com>
@jordlay jordlay changed the title Fix null as default in deployParams DONOTMERGE: Fix null as default in deployParams Apr 23, 2024
@jordlay jordlay marked this pull request as draft April 23, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants