🚧 fix: inputs get messed up when a line overflows#36
Draft
roele wants to merge 1 commit into
Draft
Conversation
roele
changed the title
jdx
reviewed
Feb 1, 2024
| // calculate potential overflow of lines overflowing terminal width | ||
| let overflow = output | ||
| .lines() | ||
| .map(|l| { |
Owner
There was a problem hiding this comment.
looks good to me. I feel like maybe with "fold" or "reduce" you could make it a tiny bit more concise but honestly I'd probably just do it the way you did
jdx
reviewed
Feb 1, 2024
| } | ||
|
|
||
| fn set_height(&mut self, output: String) -> io::Result<()> { | ||
| let height = common::get_height(&self.term, output); |
Owner
There was a problem hiding this comment.
Suggested change
| let height = common::get_height(&self.term, output); | |
| let (h, o) = common::get_height(&self.term, output); |
Owner
|
this looks like the right approach to me—definitely tough to review this kind of code though |
|
I'm also seeing the line wrapping bug from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overflowing lines need to be calculated seperately of height so we can move the cursor accordingly before clearing. for
selectsthis is much more involved since capacity of options also need to be calculated based on title,description and help which all might be overflowing.