Skip to content

Replace var with const/let across core/js + scoping fixes #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
limad wants to merge 7 commits into from
Closed

Replace var with const/let across core/js + scoping fixes #3297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d3cc2e6
Update log.class.js
limad Apr 22, 2026
ea2fafd
Update release-notes.md [skip ci]
invalid-email-address Apr 22, 2026
ac41cd3
Replace "exp var" by "let/const"
limad Apr 22, 2026
cbb75fe
Merge branch 'develop' of https://github.com/limad/core into develop
limad Apr 22, 2026
dcf3cb7
Fix scoping regressions and implicit globals from var→let/const migra…
limad Apr 25, 2026
5994bd5
Merge upstream/develop into develop
limad Apr 25, 2026
813cc63
Update release-notes.md [skip ci]
invalid-email-address Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/js/appMobile.class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jeedom.appMobile.detected = function() {
}

jeedom.appMobile.postToApp = function (_action, _options = {}) {
let message = {}
const message = {}
if (window.ReactNativeWebView != undefined) {
message.action = _action
message.options = _options
Expand Down
48 changes: 24 additions & 24 deletions core/js/backup.class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@
jeedom.backup = function() {};

jeedom.backup.backup = function(_params) {
var paramsRequired = [];
var paramsSpecifics = {};
const paramsRequired = [];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/jeedom.ajax.php';
paramsAJAX.data = {
action: 'backup',
Expand All @@ -35,16 +35,16 @@ jeedom.backup.backup = function(_params) {
}

jeedom.backup.restoreLocal = function(_params) {
var paramsRequired = [];
var paramsSpecifics = {};
const paramsRequired = [];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/jeedom.ajax.php';
paramsAJAX.data = {
action: 'restore',
Expand All @@ -54,16 +54,16 @@ jeedom.backup.restoreLocal = function(_params) {
}

jeedom.backup.remove = function(_params) {
var paramsRequired = ['backup'];
var paramsSpecifics = {};
const paramsRequired = ['backup'];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/jeedom.ajax.php';
paramsAJAX.data = {
action: 'removeBackup',
Expand All @@ -73,16 +73,16 @@ jeedom.backup.remove = function(_params) {
}

jeedom.backup.uploadCloud = function(_params) {
var paramsRequired = ['backup'];
var paramsSpecifics = {};
const paramsRequired = ['backup'];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/repo.ajax.php';
paramsAJAX.data = {
action: 'uploadCloud',
Expand All @@ -92,16 +92,16 @@ jeedom.backup.uploadCloud = function(_params) {
}

jeedom.backup.restoreCloud = function(_params) {
var paramsRequired = ['backup', 'repo'];
var paramsSpecifics = {};
const paramsRequired = ['backup', 'repo'];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/repo.ajax.php';
paramsAJAX.data = {
action: 'restoreCloud',
Expand All @@ -112,16 +112,16 @@ jeedom.backup.restoreCloud = function(_params) {
}

jeedom.backup.list = function(_params) {
var paramsRequired = [];
var paramsSpecifics = {};
const paramsRequired = [];
const paramsSpecifics = {};
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired);
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e);
return;
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
var paramsAJAX = jeedom.private.getParamsAJAX(params);
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {});
const paramsAJAX = jeedom.private.getParamsAJAX(params);
paramsAJAX.url = 'core/ajax/jeedom.ajax.php';
paramsAJAX.data = {
action: 'listBackup',
Expand Down
40 changes: 20 additions & 20 deletions core/js/cache.class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@
jeedom.cache = function() { }

jeedom.cache.set = function(_params) {
var paramsRequired = ['key', 'value']
var paramsSpecifics = {}
const paramsRequired = ['key', 'value']
const paramsSpecifics = {}
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired)
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e)
return
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {})
var paramsAJAX = jeedom.private.getParamsAJAX(params)
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {})
const paramsAJAX = jeedom.private.getParamsAJAX(params)
paramsAJAX.url = 'core/ajax/cache.ajax.php'
paramsAJAX.data = {
action: 'set',
Expand All @@ -39,16 +39,16 @@ jeedom.cache.set = function(_params) {
}

jeedom.cache.byKey = function(_params) {
var paramsRequired = ['key']
var paramsSpecifics = {}
const paramsRequired = ['key']
const paramsSpecifics = {}
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired)
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e)
return
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {})
var paramsAJAX = jeedom.private.getParamsAJAX(params)
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {})
const paramsAJAX = jeedom.private.getParamsAJAX(params)
paramsAJAX.url = 'core/ajax/cache.ajax.php'
paramsAJAX.data = {
action: 'byKey',
Expand All @@ -58,16 +58,16 @@ jeedom.cache.byKey = function(_params) {
}

jeedom.cache.remove = function(_params) {
var paramsRequired = ['key']
var paramsSpecifics = {}
const paramsRequired = ['key']
const paramsSpecifics = {}
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired)
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e)
return
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {})
var paramsAJAX = jeedom.private.getParamsAJAX(params)
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {})
const paramsAJAX = jeedom.private.getParamsAJAX(params)
paramsAJAX.url = 'core/ajax/cache.ajax.php'
paramsAJAX.data = {
action: 'remove',
Expand All @@ -77,16 +77,16 @@ jeedom.cache.remove = function(_params) {
}

jeedom.cache.clean = function(_params) {
var paramsRequired = []
var paramsSpecifics = {}
const paramsRequired = []
const paramsSpecifics = {}
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired)
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e)
return
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {})
var paramsAJAX = jeedom.private.getParamsAJAX(params)
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {})
const paramsAJAX = jeedom.private.getParamsAJAX(params)
paramsAJAX.url = 'core/ajax/cache.ajax.php'
paramsAJAX.data = {
action: 'clean'
Expand All @@ -95,16 +95,16 @@ jeedom.cache.clean = function(_params) {
}

jeedom.cache.flush = function(_params) {
var paramsRequired = []
var paramsSpecifics = {}
const paramsRequired = []
const paramsSpecifics = {}
try {
jeedom.private.checkParamsRequired(_params || {}, paramsRequired)
} catch (e) {
(_params.error || paramsSpecifics.error || jeedom.private.default_params.error)(e)
return
}
var params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {})
var paramsAJAX = jeedom.private.getParamsAJAX(params)
const params = domUtils.extend({}, jeedom.private.default_params, paramsSpecifics, _params || {})
const paramsAJAX = jeedom.private.getParamsAJAX(params)
paramsAJAX.url = 'core/ajax/cache.ajax.php'
paramsAJAX.data = {
action: 'flush'
Expand Down
Loading