Fix NaN comparisons in DataTables column sorting#3413
Open
Salvialf wants to merge 2 commits into
Open
Conversation
Salvialf
added
the
changelog-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sortDefault,sortInput,sortSelectValue,sortSelectCustomandsortCustomconverted each side of a comparison independently: numeric-looking values became anumber, non-numeric values stayed astring. Comparing anumberto a non-numericstringcoerces the string toNaN, and any comparison againstNaNreturnsfalseon both sides, which pushes numeric-looking values to one end of the sort regardless of their actual value, instead of sorting them in place among the alphanumeric ones.The fix only converts both sides to numbers when they are both non-empty and numeric. Otherwise the comparison falls back to strings on both sides, which produces a consistent order for columns mixing numeric-looking and alphabetic values, and preserves the existing numeric sort for columns that are fully numeric.