Skip to content

Fix plugin custom events never reaching native addEventListener listeners #3416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Salvialf wants to merge 3 commits into
base: develop
Choose a base branch
from
+5 −8
Open

Fix plugin custom events never reaching native addEventListener listeners #3416

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
846295e
fix(jeedom.changes): let native listeners receive custom plugin events
Salvialf Jul 6, 2026
866295f
refactor(jeedom.changes): lead with the native dispatch branch, jQuer…
Salvialf Jul 6, 2026
869f166
fix(jeedom.changes): restore dispatch for events without an option pa…
Salvialf Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions core/js/jeedom.class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jeedom.display = {}
jeedom.connect = 0
jeedom.theme = {}
jeedom.changes_timeout = null
jeedom.vanillaEvents = ['scenario::update', 'ui::update', 'jeedom::gotoplan', 'jeedom::alert', 'jeedom::alertPopup', 'jeedom::coloredIcons', 'message::refreshMessageNumber', 'update::refreshUpdateNumber', 'notify', 'checkThemechange', 'changeTheme']

jeeFrontEnd = {
__description: 'Global object where each Core page register its own functions and variable in its sub-object name.',
Expand Down Expand Up @@ -81,14 +82,10 @@ jeedom.changes = function() {
continue
}
if (isset(data.result[i].option)) {
if (['scenario::update', 'ui::update', 'jeedom::gotoplan', 'jeedom::alert', 'jeedom::alertPopup', 'jeedom::coloredIcons', 'message::refreshMessageNumber', 'update::refreshUpdateNumber', 'notify', 'checkThemechange', 'changeTheme'].includes(data.result[i].name)) {
if (jeedom.vanillaEvents.includes(data.result[i].name) || typeof jQuery !== 'function') {
document.body.dispatchEvent(new CustomEvent(data.result[i].name, { detail: data.result[i].option }))
} else {
if (typeof jQuery === 'function') {
$('body').trigger(data.result[i].name, data.result[i].option)
} else {
document.body.dispatchEvent(new CustomEvent(data.result[i].name, { detail: data.result[i].option }))
}
$('body').trigger(data.result[i].name, data.result[i].option)
}
} else {
document.body.dispatchEvent(new CustomEvent(data.result[i].name))
Expand All @@ -107,9 +104,9 @@ jeedom.changes = function() {
},
error: function(_error) {
if (typeof (user_id) != "undefined" && jeedom.connect == 100) {
if(_error.message !== 'Unknown error'){
if (_error.message !== 'Unknown error') {
jeedom.notify('{{Erreur de connexion}}', '{{Erreur lors de la connexion}} : ' + _error.message)
}
}
}
jeedom.connect++
jeedom.changes_timeout = setTimeout(jeedom.changes, 1)
Expand Down
Loading