Skip to content

Fix #337411: Crash with Qt 5.15 (on Linux / with Mu3.7)#36

Open
Jojo-Schmitz wants to merge 3 commits into
jeetee:masterfrom
Jojo-Schmitz:qt-5.15-fix
Open

Fix #337411: Crash with Qt 5.15 (on Linux / with Mu3.7)#36
Jojo-Schmitz wants to merge 3 commits into
jeetee:masterfrom
Jojo-Schmitz:qt-5.15-fix

Conversation

@Jojo-Schmitz

@Jojo-Schmitz Jojo-Schmitz commented Nov 13, 2023

Copy link
Copy Markdown
Contributor

By adding if (!beatBaseList) return;. Also fix some QtCreator warnings reg. != and == as well as 2 QtCreator errors reg. Ids being enclosed in '

Resolves: https://musescore.org/en/node/337411 (maybe)
Resolves: #27 (certainly)

@Jojo-Schmitz

Jojo-Schmitz commented Aug 23, 2025

Copy link
Copy Markdown
Contributor Author

Some of those ' to " changes are mandated by QtCreator
image
image
Therse two actually need removeing them rather than replacing them.
The others (the real changes from ' to ") seem to be purly cosmetical, and I can easily revert them it you don't like them (you mentioned the ' enclosed strings to be more performant in JavaScript on Discord?), so I'll do that now.
Changes from != and == to !== and ===, respectively, are to fix QtCreator warnings. e.g:
image

The real fix for the crash though seems that additional check and return, if (!beatBaseList) return;, IIRC (it is 3 years ago after all)
It certainly does seem to resolve #27.

@Jojo-Schmitz Jojo-Schmitz changed the title Fix #337411: Crash with Qt 5.15 (on Linux) Fix #337411: Crash with Qt 5.15 (on Linux / with Mu3.7) Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Property get is not a function (Qt 5.15)

1 participant