WIP: #180 Additional serializer infinityLoop when using FieldBitLength [3 Unit tests broken]#236
Draft
mathiash98 wants to merge 3 commits intojefffhaynes:masterfrom
Conversation
…tLength Infinity loop occurs when trying to parse a binary message that does not fit into the provided type. This commit adds an additional check when parsing to throw exception if stream.AvailableForReading < 0. This commit breaks following unit tests: - Issue55Tests - ImmutableTest2 - IOExceptionTest - ShouldThrowIOExceptionNotInvalidOperationExceptionTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref to #180
Infinity loop occurs when trying to parse a binary message that does not fit into the provided type.
This commit adds an additional check when parsing to throw exception if stream.AvailableForReading < 0 (I have used < -1 in order to Allow IOExceptionTest to pass).
This commit breaks following unit tests:
IOExceptionTest - ShouldThrowIOExceptionNotInvalidOperationExceptionTestSolved by setting threshold at -1