Skip to content

Debt repayment calculation#25

Open
Saketpawar99 wants to merge 12 commits intomainfrom
DebtRepayment_Calculation
Open

Debt repayment calculation#25
Saketpawar99 wants to merge 12 commits intomainfrom
DebtRepayment_Calculation

Conversation

@Saketpawar99
Copy link
Copy Markdown

@Saketpawar99 Saketpawar99 commented Mar 17, 2024

Updated calculation method for debt repayment.

Credit/Debit Tracker

Jira Feature/Task/Story and Link to it

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have followed the git practices outlined here to ensure code conflicts are minimized
  • My code follows the style guidelines of this project outlined here
  • I have performed a self-review of my code. It runs without errors and follows the Best Coding Practices
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • There are no API keys, passwords, usernames, or other secrets in the code. .env files are used for these secrets.
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Copy Markdown
Contributor

@audrey314 audrey314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is not functioning correctly. It is erroring when I enter valid values for available money. Additionally the math in the calculations for Avalanche method appears to be incorrect. Check lines 117 and 129.

@Saketpawar99
Copy link
Copy Markdown
Author

The code is not functioning correctly. It is erroring when I enter valid values for available money. Additionally the math in the calculations for Avalanche method appears to be incorrect. Check lines 117 and 129.

yeah I will check it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants