Document setting up extensionless feed paths#238
Open
sonicdoe wants to merge 2 commits intojekyll:masterfrom
Open
Document setting up extensionless feed paths#238sonicdoe wants to merge 2 commits intojekyll:masterfrom
sonicdoe wants to merge 2 commits intojekyll:masterfrom
Conversation
benbalter
reviewed
Jul 10, 2018
README.md
Outdated
|
|
||
| To note, you shouldn't have to do this unless you already have a feed you're using, and you can't or wish not to redirect existing subscribers. | ||
|
|
||
| <span role="img" aria-label="Warning">⚠️</span> If your feed path does not end with `.xml`, you'll need to configure your web server to serve the proper content type. Alternatively, you can specify e.g. `feed/index.xml` to serve your feed from `/feed/`. |
Contributor
There was a problem hiding this comment.
I believe using :warning: here will result in similar markup.
Author
There was a problem hiding this comment.
VoiceOver on macOS reads it slightly differently. However, I’ve noticed that GitHub converts it to their <g-emoji> custom element anyway, so I’ve changed it to :warning:. Thanks 👍
86105d5 to
4cb016b
Compare
benbalter
approved these changes
Jul 10, 2018
DirtyF
approved these changes
Jul 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #237.