Escape any stray CDATA end tokens that may be in the post contents#396
Open
Kronopath wants to merge 1 commit intojekyll:masterfrom
Open
Escape any stray CDATA end tokens that may be in the post contents#396Kronopath wants to merge 1 commit intojekyll:masterfrom
Kronopath wants to merge 1 commit intojekyll:masterfrom
Conversation
Normally you wouldn't have any CDATA end tokens ]]> in post content, because > gets converted to >. However, in certain circumstances, like HTML comments, one can slip through unescaped. The only real way to escape CDATA end tokens is to split them up. I.e. instead of having a single string ]]>, we instead have ]](end CDATA)(start another CDATA)>. The two adjacent CDATAs will then be concatenated. That looks like this very messy string: ]]]]><![CDATA[>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normally you wouldn't have any CDATA end tokens
]]>in post content, because>gets converted to>.However, in certain circumstances, like HTML comments, one can slip through the markdown parser unescaped. This totally breaks the XML, and the only way around it is to escape the end token.
The only real way to escape CDATA end tokens is to split them up. I.e. instead of having a single string
]]>, we instead have]](end CDATA) (start another CDATA)>. The two adjacent CDATAs will then be concatenated.That looks like this messy string:
]]]]><![CDATA[>. The first]]is the first part of the split token, the following]]>ends the CDATA,<![CDATA[starts another one, and the final>is the second part of the split token.This pull request does the following:
]]>strings in both post content and summary in the feed.xml as described aboveTest plan
Before the feed.xml changes (but with the test case in place):
After the feed.xml changes: