Introduce Credentials.forRun to contextualize secrets#293
Merged
jglick merged 5 commits intojenkinsci:masterfrom Mar 26, 2022
Merged
Introduce Credentials.forRun to contextualize secrets#293jglick merged 5 commits intojenkinsci:masterfrom
Credentials.forRun to contextualize secrets#293jglick merged 5 commits intojenkinsci:masterfrom
Conversation
jglick
changed the title
Credentials.forRun to comtextualize secretsCredentials.forRun to contextualize secrets
This was referenced Mar 23, 2022
MarkEWaite
added a commit
to MarkEWaite/docker-lfs
that referenced
this pull request
Mar 26, 2022
Includes GitHub App authentication enhancement from Jesse Glick for credentials by context. jenkinsci/github-branch-source-plugin#527 needs this so that it can use the enhancement in jenkinsci/credentials-plugin#293 Otherwise `withCredentials` works but `checkout scm` does not work
MarkEWaite
added a commit
to MarkEWaite/docker-lfs
that referenced
this pull request
Mar 26, 2022
jenkinsci/credentials-plugin#293 to contextualize secrets in an incremental build for testing
timja
approved these changes
Mar 26, 2022
MarkEWaite
approved these changes
Mar 26, 2022
Contributor
MarkEWaite
left a comment
MarkEWaite
left a comment
There was a problem hiding this comment.
I've run it in my Jenkins test instance and have not detected any issues. I have not exercised contextualized secrets yet in that instance.
jglick
added a commit
to jglick/github-branch-source-plugin-1
that referenced
this pull request
Mar 26, 2022
jglick
added a commit
to jglick/credentials-binding-plugin
that referenced
this pull request
Mar 26, 2022
This was referenced Mar 28, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jenkinsci/github-branch-source-plugin#527 is a demonstrated use case, and jenkinsci/conjur-credentials-plugin#21 a proposed one.
This new SPI requires use of the
CredentialsProvider.findCredentialByIdmethod, which passes a (mandatory)Runargument and is the normal way to look up a particular credential during a build. (credentials-bindinghas long used it—jenkinsci/credentials-binding-plugin#169 is the integration test—and the revised version of jenkinsci/git-plugin#1242 is able to use it consistently as well.) There are other lookup methods which take anItem(~Job) or evenItemGroup(~Jenkins/Folder/MultiBranchProject/OrganizationFolder) context, which would suffice for jenkinsci/github-branch-source-plugin#527 (which would usually be inspecting aMultiBranchProjectthough I left in support for standaloneJobprojects using thegithubplugin’s project property as well). If and when such an SPI becomes desirable, it should be possible to compatibly introduceCredentials.forItem(defaulting tothis, rewrite the default offorRunto delegate toforItem(run.getParent())) or evenforItemGroup(similar delegation chain).