[WIP] JENKINS-70101 - testing reentrance#393
Draft
jimklimov wants to merge 27 commits intojenkinsci:masterfrom
Draft
[WIP] JENKINS-70101 - testing reentrance#393jimklimov wants to merge 27 commits intojenkinsci:masterfrom
jimklimov wants to merge 27 commits intojenkinsci:masterfrom
Conversation
…des [JENKINS-70101]
…tials() et al to standalone cases
…able*() to make sure it is right
…tial" to differentiate from expected other credential types
…equest() in the same pipeline (using same bytes)
…r getUploadedKeystore()
…dedKeystore" be used to serialize
…d, must use Secret not SecretBytes
…urce() depend on Channel.current() == null
…, to make sure the snapshot is decipherable many times
…eSource: try tracing everywhere we can that we are using (and converting from) Secret for keystore [NON-PRODUCTION]
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo follow-up to #391 to have an incremental build (with some noisy println-debug attempts) taking care of conversion from Secret to SecretBytes for practical investigation.