Initial credentials implementation of experimental views#981
Initial credentials implementation of experimental views#981timja wants to merge 33 commits intojenkinsci:masterfrom
Conversation
pom.xml
Outdated
| <jenkins.version>${jenkins.baseline}.1</jenkins.version> | ||
| <jenkins.baseline>2.528</jenkins.baseline> | ||
| <!-- TODO https://github.com/jenkinsci/jenkins/pull/11333 --> | ||
| <jenkins.version>2.542-rc37822.b_14a_5941318e</jenkins.version> |
There was a problem hiding this comment.
requires noDefer from jenkinsci/jenkins#11333
| return "SECURITY"; | ||
| @NonNull | ||
| @Override | ||
| public Category getCategory() { |
| return new Api(this); | ||
| } | ||
|
|
||
| public Actionable getObject() { |
There was a problem hiding this comment.
required for job page re-work
| <l:main-panel> | ||
| <h1>${it.displayName}</h1> | ||
| <p /> | ||
| <div class="behavior-loading">${%LOADING}</div> |
There was a problem hiding this comment.
no longer needed as system pages do this by default (noDefer to skip which is needed on ViewCredentialsAction)
| </style> | ||
| xmlns:t="/lib/hudson" xmlns:d="jelly:define" xmlns:local="local"> | ||
| <d:taglib uri="local"> | ||
| <d:tag name="contents"> |
There was a problem hiding this comment.
no changes to the main page below here other than setting it into a tag
src/main/resources/com/cloudbees/plugins/credentials/ViewCredentialsAction/index.jelly
Outdated
Show resolved
Hide resolved
|
I think that's all the system settings pages sorted. Job I'll see what I can do but I think its missing functionality. I'll need to do a pass over all the user pages as well and make sure they are all fine / if there's any cleanup that can be done for them (there should be) |
|
@janfaracik there's something quite off with tables in core they can break out of the container and scroll the page =/ Adding sidepanel and using a table layout doesn't work very well. Thoughts? This is my credential that really breaks the layout on a 13" screen: |
|
To fix this case I'm thinking of doing something like: 
Previously: 
That would be looping over each store and not repeating all that information in the table. |
|
@janfaracik you able to check this over? I think its all working now. I removed the job subpage as it didn't really seem to work for this at all and it needs more work. I'll look at doing a PR to rework the table soon as well I don't think its 100% essential to be in before this |
Looking good - no obvious issues. I think it'll work a lot better once the cards are in. Wouldn't repeat the app bar buttons on various configure pages, e.g. I'd remove Update/Delete from the Move page, but if we do go down a dialog route this is fine for now. |
|
I think this is ready after the next weekly release. |
PR here to show what it'll look like: #985 |
|
Merging master into this ... will be broken for a few minutes. |
|
@timja am I good to delete the |
|
This is looking good to me @timja |
2 participants
Closes #626
Part of jenkinsci/sig-ux#10
Known issues:
help link to system / job credentials page not implementedScreenshot
Details
Screenshot
Screenshot
cc @janfaracik
Testing done
Submitter checklist