Fail getEC2HostAddress for a terminated instance#1126
Merged
res0nance merged 2 commits intojenkinsci:masterfrom Aug 2, 2025
Merged
Fail getEC2HostAddress for a terminated instance#1126res0nance merged 2 commits intojenkinsci:masterfrom
getEC2HostAddress for a terminated instance#1126res0nance merged 2 commits intojenkinsci:masterfrom
Conversation
3 tasks
nevingeorgesunny
approved these changes
Aug 1, 2025
res0nance
approved these changes
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #1121.
While testing without #1125, as I recall (not sure exactly how to reproduce), I ran into some cases where the metadata inside the Jenkins controller was apparently out of date and there was an EC2 agent definition that corresponded to an instance which had already been terminated. This was not handled gracefully: the launch log went into a loop whereby it would claim that the hostname was not yet ready and it was going to sleep and try again in a few seconds. Clearly at this point the agent cannot be launched because the instance is gone, so it should fail early and clearly. With this patch, the agent definition gets deleted automatically.