Skip to content

Update m8i and m8a instance types to InstanceTypeCompat#2009

Open
peterzhuamazon wants to merge 1 commit intojenkinsci:masterfrom
peterzhuamazon:add-m8-instances
Open

Update m8i and m8a instance types to InstanceTypeCompat#2009
peterzhuamazon wants to merge 1 commit intojenkinsci:masterfrom
peterzhuamazon:add-m8-instances

Conversation

@peterzhuamazon
Copy link
Copy Markdown

Update m8i and m8a instance types to InstanceTypeCompat.
Similar to: #1139

Available instance types:
https://aws.amazon.com/ec2/instance-types/m8i/
https://aws.amazon.com/ec2/instance-types/m8a/

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Copy Markdown
Author

Hi @res0nance would you mind take a look and approve/merge?
We are trying to add new m8 instance types.
Let me know if this is the right way to proceed. Thanks!

Copy link
Copy Markdown

@andrross andrross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I cross-checked the instance types against the AWS instance type names and they appear to be correct.

@eukazakov
Copy link
Copy Markdown

Hi!
We are looking forward to using these instance types on Jenkins.
Could you share when we can expect it to be released?
Thanks!

@res0nance
Copy link
Copy Markdown
Contributor

Does updating your aws-sdk not bring the latest instance types?

@eukazakov
Copy link
Copy Markdown

I don't see any updates for the aws-sdk for Jenkins
we have the next versions
Amazon EC2Version 2049.v127f0f109c29
Amazon Web Services SDK 2 :: EC2Version 2.42.33-70.vd69c0763fa_60

@res0nance
Copy link
Copy Markdown
Contributor

We should not have to add to this list https://github.com/jenkinsci/ec2-plugin/pull/1065/changes#r2023225515

@eukazakov
Copy link
Copy Markdown

then what should we do to access these m8a instance types on Jenkins?
we don't have them in the list atm

@peterzhuamazon
Copy link
Copy Markdown
Author

Yes @res0nance since we are not familiar with this plugin, I have same question as @eukazakov . What should we do to access newer instance types like m8. Thanks.

@peterzhuamazon
Copy link
Copy Markdown
Author

Hi @res0nance is the any update here?
Or could you help suggest how to actually enable m8 instances without this change on existing EC2 Plugin release?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants