README: Groovy script: fix UnixData and AmazonEC2Cloud#451
Merged
res0nance merged 1 commit intojenkinsci:masterfrom Jun 22, 2020
Merged
Conversation
Contributor
Author
|
There are other updates to README: https://github.com/vazhnov/ec2-plugin/tree/README_improvments , I'm going to create pull request next after this one. |
thoulen
requested review from
res0nance and
thoulen
and removed request for
thoulen
res0nance
approved these changes
Apr 27, 2020
|
The tag configuration needs to be updated, as well. The current example only shows one tag, and it doesn't save properly. Trying to launch the slave will cause a jenkins error. |
Contributor
Author
|
@bschaefer99 , let's merge this one and maybe later I can create patch for that you pointed — right now I can't check slave node launch. |
Contributor
Author
|
Guys, let's merge this one and then merge next improvements https://github.com/vazhnov/ec2-plugin/tree/README_improvments while here is no conflicts in branches. |
Contributor
Author
|
@res0nance , thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a fix for the example "Configure plugin via Groovy script".
Error # 1:
Error # 2:
P.S.: I don't know Java, so please check syntax and logic, maybe I did wrong fix. But Jenkins script console works fine with this fix.