add host-key verification strategy check-static#483
Open
cgroschupp wants to merge 7 commits intojenkinsci:masterfrom
Open
add host-key verification strategy check-static#483cgroschupp wants to merge 7 commits intojenkinsci:masterfrom
cgroschupp wants to merge 7 commits intojenkinsci:masterfrom
Conversation
cgroschupp
force-pushed
the
feat/ssh-check-static
branch
from
e02a168 to
d2455f8
Compare
Author
|
ready to review. |
|
+1 for this change |
res0nance
requested changes
Aug 12, 2020
| String instanceCapStr, String iamInstanceProfile, boolean deleteRootOnTermination, | ||
| boolean useEphemeralDevices, boolean useDedicatedTenancy, String launchTimeoutStr, boolean associatePublicIp, | ||
| String customDeviceMapping, boolean connectBySSHProcess, boolean monitoring, | ||
| boolean t2Unlimited, ConnectionStrategy connectionStrategy, int maxTotalUses, List<? extends NodeProperty<?>> nodeProperties, String staticHostKeys) { |
Contributor
There was a problem hiding this comment.
Please don't modify existing constructors
Member
|
I don't have bandwith these days. @MRamonLeon could you please have a look at this PR? Because you worked on the host-key verification, your review might be actual valuable. |
|
Any progress on this? |
MRamonLeon
reviewed
Sep 2, 2020
| while (scanner.hasNextLine()) { | ||
| String hostKeyString = scanner.nextLine(); | ||
| String[] hostKeyParts = hostKeyString.split(" "); | ||
| if (hostKeyParts.length < 2 || hostKeyParts.length > 3) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (hostKeyParts.length < 2 || hostKeyParts.length > 3) { | |
| if (hostKeyParts.length != 2) { |
| String hostKeyString = scanner.nextLine(); | ||
| String[] hostKeyParts = hostKeyString.split(" "); | ||
| if (hostKeyParts.length < 2 || hostKeyParts.length > 3) { | ||
| EC2Cloud.log(LOGGER, Level.WARNING, computer.getListener(), "The provided static SSH key is invalid"); |
Contributor
There was a problem hiding this comment.
If you add the reason it would be appreciated, like:
the format is algorithm base64-public-key, example: ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIHm0sVqkjSuaPg8e7zfaKXt3b1hE1tBwFsB18NOWv5ow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.