inclusive language tags: jenkins_slave_type renamed to jenkins_node_type

[nitrocode]

I know there are many other master/slave references. This one will only correct the issue with jenkins ec2 worker tags.

This is also consistent with Jenkins using the word node for their workers.

Ref: https://tools.ietf.org/id/draft-knodel-terminology-02.html

Ticket: https://issues.jenkins-ci.org/browse/JENKINS-63660

[nitrocode]

Hi @fcojfernandez @res0nance @MRamonLeon

What are some of the thoughts on this ?

[res0nance]

This is going to break the node counting. Not sure how to best handle this

[nitrocode]

Where is node counting codified?

[res0nance]

ec2-plugin/src/main/java/hudson/plugins/ec2/EC2Cloud.java

Line 606 in dfa60b7

private List<Filter> getGenericFilters(String jenkinsServerUrl, SlaveTemplate template) {

[nitrocode]

Thanks. It sounds like it might be best to have logic to count both the jenkins_slave_type and jenkins_node_type tag names but tag the latter going forward for newly created instances. For the getGenericFilters, we could count both tag names. I'll put in some more work.

Relevant code references (for myself):

• https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/ec2/model/Filter.html
• https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/ec2/model/Tag.html

[dannykansas]

What additional changes are needed, if any, for this to be ready for the next release?

[res0nance]

What additional changes are needed, if any, for this to be ready for the next release?

Something to make it backwards compatible, as is this will break backwards compatibility