Test/implement windows ssh#990
Conversation
|
EC2WindowsSSHLauncher in this pull request is essential for launching EC2 Windows instance as a Jenkins Agent form Linux Jenkins Controller, because Linux Controller cannot access Windows Agent by EC2WindowsLauncher that uses WinRM that requires WSMan, which is not supported on Linux. |
There was a problem hiding this comment.
This PR enables to launch EC2 Windows agent via ssh. Current EC2WindowsLauncher communicates to Windows agents via WinRM, which is not supported on Linux. So Linux Jenkins controller could not launch Windows agent.
EC2WindowsSSHLauncher in this PR enables for Linux controller to control Windows agent with ssh.
This PR also includes the following good refactoring AMITypeData and EC2ComputerLauncher class hierarchy.
- Introduces SSHData as a base class of UnixData, MacData, and WindowsSSHData.
- Introduces EC2SSHLauncher as a base class of EC2UnixLauncher, EC2MacLauncher, and EC2WindowsSSHLauncher.
All code modifications look fine to me. I believe this PR brings a large enhancement for Jenkins users that uses Windows agents.
|
Hey it looks like this has a merge conflict. Could you rebase this? Also has anyone done any testing on this? |
Testing done
Submitter checklist