-
-
Notifications
You must be signed in to change notification settings - Fork 22
docs: clarify that AWS Bedrock requires the optional AWS SDK plugin #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+32
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
src/test/java/io/jenkins/plugins/explain_error/provider/BedrockProviderRegistrationTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package io.jenkins.plugins.explain_error.provider; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
| import org.jvnet.hudson.test.JenkinsRule; | ||
| import org.jvnet.hudson.test.junit.jupiter.WithJenkins; | ||
|
|
||
| /** | ||
| * Guards that the AWS Bedrock provider is wired up as a selectable AI provider | ||
| * when its dependency is available. | ||
| * | ||
| * <p>The System configuration dropdown is populated by descriptor discovery over | ||
| * {@link BaseAIProvider}. The Bedrock descriptor is registered only when the | ||
| * {@code aws-java-sdk2-core} plugin is present — an intentionally optional | ||
| * dependency, so instances that do not use Bedrock are not forced to carry the | ||
| * AWS SDK. The test harness provides that dependency, so this test verifies the | ||
| * descriptor is correctly registered (via {@code @OptionalExtension} and | ||
| * {@code @Symbol}) whenever the AWS SDK plugin is installed. | ||
| */ | ||
| @WithJenkins | ||
| class BedrockProviderRegistrationTest { | ||
|
|
||
| @Test | ||
| void bedrockProviderIsSelectable(JenkinsRule jenkins) { | ||
| boolean registered = jenkins.jenkins.getDescriptorList(BaseAIProvider.class).stream() | ||
| .anyMatch(descriptor -> descriptor instanceof BedrockProvider.DescriptorImpl); | ||
| assertTrue(registered, | ||
| "AWS Bedrock provider descriptor must be registered and selectable in the AI Provider list"); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.