UI refinements and code cleanup#97
Conversation
Refines the config screens to be be in sync with current best practices - remove tr in config screens - remove f:block - apply propery styling for selects Refine the columns - place most tooltips on a span instead of the td to avoid that the tooltip looks misplaced when the column is much wider than the actual content - make links to agents, job or build use the same styling as in core - make the agent allocation a link to the label when it is not a selfLabel - add a tooltip with the agents description for the Last Build Node column some code cleanup in java - use pattern variables - use isEmpty for lists
| triggers = ((AbstractProject<?, ?>) job).getTriggers(); | ||
| } if (job instanceof ParameterizedJobMixIn.ParameterizedJob) { | ||
| triggers = ((ParameterizedJobMixIn.ParameterizedJob)job).getTriggers(); | ||
| if (job instanceof ParameterizedJobMixIn.ParameterizedJob<?, ?> pj) { |
There was a problem hiding this comment.
An AbstractProject is a ParameterizedJobMixIn.ParameterizedJob so that can be simplified.
|
Thank you for this pull request. As a general observation, splitting it up into several smaller PRs would have made it a bit easier to review. I hate to ask this, but did you use any AI-tooling to generate this PR? 😬 |
|
Might be some copilot auto complete proposals that did fit though many didn't fit. But that's it. No asking copilot, claude or cline to do things (as it can be seen a lot in core lately, where it is sometimes obvious that they don't really understand the generated code). |
I will split this into several PRs |
2 participants
Refines the config screens to be be in sync with current best practices
Refine the columns
some code cleanup in java
Testing done
Interactive testing
Submitter checklist