Fixes JENKINS-21332 https://issues.jenkins-ci.org/browse/JENKINS-21332#1
Fixes JENKINS-21332 https://issues.jenkins-ci.org/browse/JENKINS-21332#1mkutter wants to merge 2 commits into
Conversation
* Moved fortifyclient-{version}.jar files to WEB-INF/fortify-lib/
* adjusted FortifyClientClassloader to load from pluginWrapper.getBaseUrl("WEB-INF/fortify-lib/fortifyclient-" + version + ".jar");
* adjusted test (needs Jenkins Test Harness now - only works with plugin loaded)
Signed-off-by: Martin Kutter <martin.kutter@fen-net.de>
|
plugins » fortify360-plugin #4 FAILURE |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
plugins » fortify360-plugin #5 FAILURE |
|
Whats the go with this pull request? we need this bug fixed as we are getting the same error using:
|
|
Hi everyone, we're in the process of transition the plugin maintenance to another person (Sam Ng to Anna Karyakina), so please excuse the delays with pull requests processing. The fix looks quite reasonable, but we will be able to examine it and integrate next week the earliest. |
|
One thing I have noticed in the suggested fix that looks wrong; it loads the foritfy client JAR from '$PLUGIN_ROOT/WEB-INF/fortify-lib' but looking at the installed plugin folder structure the lib files are packaged in '$PLUGIN_ROOT/WEB-INF/lib'. This is in jenkins 1.538 & jenkins-fortify plugin 3.9. |
|
Is the plugin still compatible with Jenkins 1.323 after this change? Or should the parent dependency in the pom be changed? |
|
I'm not sure whether the Jenkins version should be changed - loading the fortifyclient jars from fortify-lib/ should work in any jenkins version where PluginWrapper.baseResourceURL is available. I haven't tested with a Jenkins that old though. |
|
What is the status of this pull request? We need it to. |
7 participants
This pull request fixes the issue in the title by moving the fortifyclient-{Version}.jar files from the classes/ directory to a separate fortify-lib directory in the plugin's WEB-INF/ folder.
Changes in detail are: